Fix exporter unittest occasional error #4
Closed
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few days ago, I open a pr open-telemetry#2987 , try fix golangci-lint not working correctly. But the pr checks occur a error in unittest
TestExporterShutdown/testClientStopHonorsTimeout
for exporter grpc clientStop()
function :exporters/otlp/otlptrace/otlptracegrpc/client.go#L130I figure out in
Stop(ctx context.Context)
theselect
for<-ctx.Done()
andacquired
may reach at the same time. Inselect
ifacquired
be exec first, TheStop(ctx context.Context)
function may return nil . whenStop(ctx context.Context)
function return nil, unittestTestExporterShutdown/testClientStopHonorsTimeout
andTestExporterShutdown/testClientStopHonorsTimeout
will failure.This is a occasional error. you can recurrent it by this shell.